[apparmor] [PATCH] Fix expr tree node labeling
John Johansen
john.johansen at canonical.com
Wed Jul 7 19:16:25 BST 2010
On 07/07/2010 10:58 AM, John Johansen wrote:
> expression tree node labeling is used during debugging dumps. Currently the node labels
> are computed and stored in a map, that is not cleaned up. This means that the labeling
> is retained across different dfas.
>
> Move the labeling into expr node as this takes less memory than using a map and will
> also separates node labeling so its per dfa instead of global. In addition this means
> the labeling is cleanedup/freed when the expr tree is freed without any extra work.
>
I would like to nominate this patch for 2.5.1 as it reduces peak memory usage, especially
for profiles with lots of hats as the labeling map grows with each hat added.
More information about the AppArmor
mailing list