[apparmor] [PATCH 11/11] Move dfa minimization and remove unreachable outside of dfa creation

[Steve Beattie]

On Mon, Nov 08, 2010 at 04:27:11PM -0800, John Johansen wrote:
> On 11/08/2010 03:49 PM, Steve Beattie wrote:
> > On Mon, Oct 18, 2010 at 05:20:43PM -0700, John Johansen wrote:
> >> As from a library pov they should be seperately callable fns, and this will
> >> help reduce peak memory usage in some cases.
> >>
> >> Also disbale remove_unreachable, as the current dfa code isn't generating
> >> unreachable states, and minimization removes any states that are connected
> >> but redundant.
> > 
> > ACK. A debugging flag that verifies that post-minimization that there
> > are no unreachable or redundant states post-minimization might be useful
> > for catching bugs.
> > 
> Hrmmm, So are you asking for something more than just toggling the
> -O remove-unreachable
> 
> which outputs if it removed states?

I think I'm looking for increased sanity checks on the generated DFA so
that we can do things like run the parser stress test and verify that
what is emitted isn't bogus, particularly as you go along improving it.
But what I have in mind isn't really well-formed, just a general desire
to ensure we don't break things and not notice it as we go along.

-- 
Steve Beattie
<sbeattie at ubuntu.com>
http://NxNW.org/~steve/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
Url : https://lists.ubuntu.com/archives/apparmor/attachments/20101108/553ae28f/attachment.pgp