[apparmor] PATCH [2/2] force update of stale cache

[John Johansen]

On 09/14/2010 11:15 AM, Kees Cook wrote:
> On Tue, Sep 14, 2010 at 03:53:06AM -0700, John Johansen wrote:
>> This patch forces a cache update in the case that There is a cache file
>> that is present and invalid, and the features of the kernel and cache match.  This is done even if the-W flag is not specified.
> 
> NAK on this; I feel strongly that cache writing should only happen when the
> tool is explicitly directed to write them out. (This is supported by the
> caching test which fails when this patch is applied.)
> 

I won't contest it for now. The problem becomes that we revert to old
straight load performance if the cache test fails.  In the case that
we already have a cache file it make sense to invalidate and update it.
I will certainly agree that a cache file should not ever be automatically
generated.

If this is causing the caching tests to fail the patch certainly needs
to be fixed/extended.

thanks kees