[apparmor] Patch for apparmor.d.pod

[Steve Beattie]

On Fri, Apr 01, 2011 at 08:56:51PM +0200, Christian Boltz wrote:
> Am Freitag, 1. April 2011 schrieb Steve Beattie:
> > Acked-By: Steve Beattie <sbeattie at ubuntu.com>
> > 
> > Feel free to commit it yourself. And thanks!
> 
> Done - r1706 (trunk only).

Thanks!

> BTW: Is there a way to get a notification mail for all commits?

Yes, go to
https://code.launchpad.net/~apparmor-dev/apparmor/master/+subscribe
; you'll need to edit the Notification Level setting to
include revision notifications. (Annoyingly, you have to
set up a subscription for each branch your interested in,
e.g. to subscribe to the 2.6 branch commits, you have to go to
https://code.launchpad.net/~apparmor-dev/apparmor/2.6/+subscribe and
do the same thing.)

> > Do note that we have a policy on reviews before commits as documented
> > at http://wiki.apparmor.net/index.php/CommitPolicy -- 
> 
> OK, good to know. So basically the way is
> - send the patch to this mailinglist
> - get at least one ACK (and no NACK)
> - commit

Yes. Also, if you get radio silence for a week, you can also commit,
though to be polite, you may wish to send a second prompt for a
review, before doing so. (Prodding on the #apparmor oftc irc channel
is another option.)

> > for the
> > apparmor.vim stuff we could grant an exception for you, just as we
> > did for the distro specific abstractions bits.
> 
> That might make sense, but it's not up to me to decide ;-)
> 
> OTOH, I have no problem with sending a patch before commiting if someone 
> is interested in proofreading the apparmor.vim changes. Just tell me 
> what way you prefer.

Really, it's up to you: if you want the exception, we can discuss it. I
personally think having others review my code makes it end up being
better code, and so I (mostly :-) ) don't consider it a hassle. But
if you think it will be an impediment to you making updates to the
vim syntax files, then we should consider an exception.

Perhaps the way to go would be to see how it goes without the
exception, and re-evaluate if you start to feel you're not getting
timely reviews. Does that sound okay?

-- 
Steve Beattie
<sbeattie at ubuntu.com>
http://NxNW.org/~steve/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20110401/38751f4c/attachment.pgp>