[apparmor] [patch] apparmor-utils: Add support for creds and path operations (apparmor-utils-add-log-types)

[Steve Beattie]

On Thu, Aug 18, 2011 at 03:50:35PM -0700, John Johansen wrote:
> --- utils/Immunix/AppArmor.pm	2011-08-17 23:26:41 +0000
> +++ utils/Immunix/AppArmor.pm	2011-08-18 22:49:58 +0000
> @@ -2861,7 +2861,8 @@
>               $e->{operation} eq "truncate" ||
>               $e->{operation} eq "mkdir" ||
>               $e->{operation} eq "rename_src" ||
> -             $e->{operation} eq "rename_dest") {
> +             $e->{operation} eq "rename_dest" ||
> +             $e->{operation} =~ m/^(unlink|rmdir|symlink_create|link)$/) {
>          add_to_tree( $e->{pid},
>  		     $e->{parent},
>                       "path",
> 
> NAK, and an ACK for the slightly revised patch (attached).  Basically
> several of the operation where already in AppArmor.pm upstream so I
> removed those ones from the list

One of the concerns I had when I briefly looked at this patch was
whether the added operation included new or different tags (name2)
that the particular if-statement didn't yet handle, but I never had
time to track down if this was the case.

-- 
Steve Beattie
<sbeattie at ubuntu.com>
http://NxNW.org/~steve/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20110822/f89fdede/attachment.pgp>