[apparmor] [PATCH 4/6] Update swig to export all current interface fns

Seth Arnold seth.arnold at gmail.com
Fri Feb 18 01:53:42 UTC 2011


Looks good, one small question later:

On Thu, Feb 17, 2011 at 5:22 PM, John Johansen
<john.johansen at canonical.com> wrote:
> Signed-off-by: John Johansen <john.johansen at canonical.com>
> ---
>  libraries/libapparmor/swig/SWIG/libapparmor.i |   13 ++++++++++---
>  1 files changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/libraries/libapparmor/swig/SWIG/libapparmor.i b/libraries/libapparmor/swig/SWIG/libapparmor.i
> index 014839a..f6d1001 100644
> --- a/libraries/libapparmor/swig/SWIG/libapparmor.i
> +++ b/libraries/libapparmor/swig/SWIG/libapparmor.i
> @@ -2,13 +2,20 @@
>
>  %{
>  #include "aalogparse.h"
> -extern int aa_change_hat(const char *subprofile, unsigned long magic_token);
> -extern int aa_change_profile(const char *profile, unsigned long magic_token);

Is this mistake large enough to warrant a bug report anywhere? Or is
it a case of no clients, no point bothering? :)

> +#include "apparmor.h"
>
>  %}
>
>  %include "typemaps.i"
>  %include "aalogparse.h"
> +
> +/* swig doesn't like the macro magic we do in apparmor.h so the fn prototypes
> + * are manually inserted here
> + */
> +
>  extern int aa_change_hat(const char *subprofile, unsigned long magic_token);
> -extern int aa_change_profile(const char *profile, unsigned long magic_token);
> +extern int aa_change_profile(const char *profile);
> +extern int aa_change_onexec(const char *profile);
> +extern int aa_change_hatv(const char *subprofiles[], unsigned int token);
> +extern int aa_change_hat_vargs(unsigned int token, int count, ...);

Thanks



More information about the AppArmor mailing list