[apparmor] [Bug 737074] Re: apache2 apparmor module missing link against libapparmor

[Seth Arnold]

On Thu, Mar 17, 2011 at 1:13 PM, Steve Beattie <steve at nxnw.org> wrote:
> And for list review, the patch is below. This is both for trunk and 2.6.
> Based on this issue, I'd like to spin a 2.6.1 release soon.

I like this patch. I know you said that 2.5 doesn't need this patch, but
I prefer this style -- would it make sense to also apply it to 2.5, both for
consistency and because I like the looks of it? :)

2.6.1 to fix this soon sounds like a great idea to me.

Thanks

> === modified file 'changehat/mod_apparmor/Makefile'
> --- changehat/mod_apparmor/Makefile     2011-02-08 16:18:36 +0000
> +++ changehat/mod_apparmor/Makefile     2011-03-17 19:33:50 +0000
> @@ -41,12 +41,13 @@
>              fi )
>  APXS_INSTALL_DIR=$(shell ${APXS} -q LIBEXECDIR)
>  DESTDIR=
> -LIBAPPARMOR_FLAGS="-I../../libraries/libapparmor/src -L../../libraries/libapparmor/src/.libs -lapparmor"
> +LIBAPPARMOR_FLAGS="-I../../libraries/libapparmor/src -L../../libraries/libapparmor/src/.libs"
> +LDLIBS="-lapparmor"
>
>  all: $(TARGET) ${MANPAGES} ${HTMLMANPAGES}
>
>  %.so: %.c
> -       ${APXS} ${LIBAPPARMOR_FLAGS} -c $<
> +       ${APXS} ${LIBAPPARMOR_FLAGS} -c $< ${LDLIBS}
>        mv .libs/$@ .
>
>  .PHONY: install