[apparmor] [PATCH] LP: #781961 incorrect format string in Perl utils

[Seth Arnold]

Looks good to me, nice catch Emanuel :)
-----Original Message-----
From: Kees Cook <kees at ubuntu.com>
Sender: apparmor-bounces at lists.ubuntu.com
Date: Fri, 13 May 2011 02:25:16 
To: <apparmor at lists.ubuntu.com>
Subject: [apparmor] [PATCH] LP: #781961 incorrect format string in Perl utils

This fixes a bug in sprintf use in a few of the Perl tools, reported by
Emanuel Bronshtein in LP: #781961.

Signed-off-by: Kees Cook <kees.cook at canonical.com>

=== modified file 'utils/aa-audit'
--- utils/aa-audit	2011-01-13 21:58:26 +0000
+++ utils/aa-audit	2011-05-13 09:18:30 +0000
@@ -1,6 +1,7 @@
 #!/usr/bin/perl
 # ----------------------------------------------------------------------
 #    Copyright (c) 2005 Novell, Inc. All Rights Reserved.
+#    Copyright (c) 2011 Canonical, Ltd.
 #
 #    This program is free software; you can redistribute it and/or
 #    modify it under the terms of version 2 of the GNU General Public
@@ -116,7 +117,7 @@
             UI_Info(sprintf(gettext('Can\'t find %s in the system path list.  If the name of the application is correct, please run \'which %s\' as a user with the correct PATH environment set up in order to find the fully-qualified path.'), $profiling, $profiling));
             exit 1;
         } else {
-            UI_Info(sprintf(gettext('%s does not exist, please double-check the path.') . $profiling));
+            UI_Info(sprintf(gettext('%s does not exist, please double-check the path.'), $profiling));
             exit 1;
         }
     }

=== modified file 'utils/aa-autodep'
--- utils/aa-autodep	2011-01-13 21:58:26 +0000
+++ utils/aa-autodep	2011-05-13 09:18:08 +0000
@@ -1,6 +1,7 @@
 #!/usr/bin/perl
 # ----------------------------------------------------------------------
 #    Copyright (c) 2005 Novell, Inc. All Rights Reserved.
+#    Copyright (c) 2011 Canonical, Ltd.
 #
 #    This program is free software; you can redistribute it and/or
 #    modify it under the terms of version 2 of the GNU General Public
@@ -106,7 +107,7 @@
             UI_Info(sprintf(gettext('Can\'t find %s in the system path list.  If the name of the application is correct, please run \'which %s\' as a user with the correct PATH environment set up in order to find the fully-qualified path.'), $profiling, $profiling));
             exit 1;
         } else {
-            UI_Info(sprintf(gettext('%s does not exist, please double-check the path.') . $profiling));
+            UI_Info(sprintf(gettext('%s does not exist, please double-check the path.'), $profiling));
             exit 1;
         }
     }

=== modified file 'utils/aa-enforce'
--- utils/aa-enforce	2011-01-13 21:58:26 +0000
+++ utils/aa-enforce	2011-05-13 09:20:16 +0000
@@ -1,6 +1,7 @@
 #!/usr/bin/perl
 # ----------------------------------------------------------------------
 #    Copyright (c) 2005 Novell, Inc. All Rights Reserved.
+#    Copyright (c) 2011 Canonical, Ltd.
 #
 #    This program is free software; you can redistribute it and/or
 #    modify it under the terms of version 2 of the GNU General Public
@@ -126,7 +127,7 @@
             UI_Info(sprintf(gettext('Can\'t find %s in the system path list.  If the name of the application is correct, please run \'which %s\' as a user with the correct PATH environment set up in order to find the fully-qualified path.'), $profiling, $profiling));
             exit 1;
         } else {
-            UI_Info(sprintf(gettext('%s does not exist, please double-check the path.') . $profiling));
+            UI_Info(sprintf(gettext('%s does not exist, please double-check the path.'), $profiling));
             exit 1;
         }
     }


-- 
Kees Cook
Ubuntu Security Team

-- 
AppArmor mailing list
AppArmor at lists.ubuntu.com
Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/apparmor