[apparmor] [PATCH] split parser build into "arch" "indep" and "check"

[Kees Cook]

On Fri, May 27, 2011 at 02:33:40PM -0700, Steve Beattie wrote:
> On Fri, May 27, 2011 at 02:19:11PM -0700, Kees Cook wrote:
> > In some cases, it is desirable to build the parser without building the
> > binary portions (Hurd). This patch splits up the build targets so this is
> > possible:
> > 
> > "main" becomes "arch"
> > 
> > "indep" is created and depends on "docs"
> > po building is moved from "main" to "indep"
> > 
> > "all" has "tests" removed (standard build practices are to "make" then
> > "make check" so I think "tests"/"check" should stay separate from "all").
> 
> On the one hand, I dislike this because I'm afraid people will skip
> running the parser tests before submitting patches to the parser. On
> the other hand, we've accumulated enough tests for the parser that it
> interferes with the compile/debug cycle to run all the tests and this
> will mitigate that (though you could work around it in its existing
> state by doing 'make apparmor_parser').

Yeah, I was on the fence a bit, but another goal I have is moving us closer
to an autoconf/automake world. In that situation, the tests will be
separate too, so this gets us the behavior change earlier so it'll
hopefully be less of a shock when we get all the way to autoconf/automake.

> I guess in the end, ACK from me, though you should purge the "not
> strictly necessary" comment from /README:
> 
> parser:
> $ cd parser
> $ make
> $ make tests    # not strictly necessary as they are run during the
>                 # build by default
> $ make install

Oh! Yes, good catch.

-Kees

-- 
Kees Cook
Ubuntu Security Team