[apparmor] [patch] Two patches to AppArmor.pm/autodep

[Christian Boltz]

Hello,

Am Dienstag, 10. Januar 2012 schrieb John Johansen:
> On 01/10/2012 09:53 AM, Steve Beattie wrote:
> > On Mon, Jan 09, 2012 at 10:03:45PM +0100, Christian Boltz wrote:
> >> Am Montag, 9. Januar 2012 schrieb Steve Beattie:
> >>> This patch updates the initial profile generation for python
> >>> and ruby scripts to include the respective abstractions.

> >>> This patch fixes the profile autogeneration code to include
> >>> read
> >>> access to the script itself for interpreted scripts.
> >> 
> >> Those patches sound useful for 2.7 also - will you backport
> >> them?
> > 
> > I talked briefly with John about it, and he felt they were
> > enhancements rather than bug fixes and thus less appropriate for
> > the 2.7 branch.

May I hand over an axe to you to split this hair? ;-)

> right, though I don't have a strong objection to it going into 2.7
> either. I won't deny they could be useful, and the one could even be
> considered a bug fix, but the bug is minor and only leads to an extra
> step in creating a profile. 

I would call both patches bugfixes. They fix the "genprof asks 
superfluous and obvious questions" usability bug ;-) and also keep the 
audit.log smaller (= better genprof performance) because everything in 
the abstractions doesn't need to be logged.

> We certainly have pushed some features
> into point releases in the past. Basically if this is something you
> would really like to see in the point release its worth considering.

It's not a killer feature/bugfix, but nevertheless it's a bugfix. 
In other words:

for both patches:
Acked-by: Christian Boltz <apparmor at cboltz.de> for the 2.7 branch


Regards,

Christian Boltz
-- 
Und da ich falsch geschrieben habe, was ja flasch ist, da faslch richtig
geschrieben ja richtig und nicht falcsh ist, hab ich durch das richtige
schreiben einen Fehler gemacht und damit das Wort flasch richtig ver- 
wendet, da es ja flashc ist, was hier nicht richtig, aber passend ist.
[Till Potinius]