[apparmor] [patch 4/7] parser: remove unneeded e_buffer_overflow

Steve Beattie steve at nxnw.org
Tue Dec 17 21:00:58 UTC 2013


As noted by Seth Arnold, e_buffer_overflow is no longer set in
convert_aaregex_to_pcre(), so remove it and the sole check for it.

Signed-off-by: Steve Beattie <steve at nxnw.org>
---
 parser/parser_regex.c |    6 ------
 1 file changed, 6 deletions(-)

Index: b/parser/parser_regex.c
===================================================================
--- a/parser/parser_regex.c
+++ b/parser/parser_regex.c
@@ -42,7 +42,6 @@
 enum error_type {
 	e_no_error,
 	e_parse_error,
-	e_buffer_overflow
 };
 
 /* Filters out multiple slashes (except if the first two are slashes,
@@ -377,11 +376,6 @@ static pattern_t convert_aaregex_to_pcre
 	}
 	/* check error  again, as above STORE may have set it */
 	if (error != e_no_error) {
-		if (error == e_buffer_overflow) {
-			PERROR(_("%s: Internal buffer overflow detected, %d characters exceeded\n"),
-			       progname, PATH_MAX);
-		}
-
 		PERROR(_("%s: Unable to parse input line '%s'\n"),
 		       progname, aare);
 




More information about the AppArmor mailing list