[apparmor] [PATCH] parser: Add make variable to build against local or system libapparmor

[John Johansen]

On 12/20/2013 11:06 PM, Steve Beattie wrote:
> On Tue, Dec 10, 2013 at 01:36:10PM -0800, Seth Arnold wrote:
>> Is building against the in-tree version the "best" default?
> 
> Yes. If there's been any development of the parser that depends on
> features of libapparmor that are newer than your system's libapparmor,
> then your compilation will fail. As a specific example, trunk's
> apparmor regression tests fail to compile on Ubuntu 12.04 LTS, because
> the query_label test program depends on the query interface added to
> libapparmor, which isn't present in 12.04's version of libapparmor.
> 
> This will become more of an issue if we push some of the functionality
> currently in the parser into libapparmor, as is (long-term) planned.
> 
> On Fri, Dec 06, 2013 at 08:57:57PM -0800, Tyler Hicks wrote:
>> By default, statically link against the in-tree libapparmor. If the
>> in-tree libapparmor is not yet built, print a helpful error message.
>> To build against the system libapparmor, the SYSTEM_LIBAPPARMOR make
>> variable can be set on the command line like so:
>>
>>   $ make SYSTEM_LIBAPPARMOR=1
> 
> I suspect we also want a helpful message if SYSTEM_LIBAPPARMOR is set
> but the system libraries and/or header cannot be found, indicating
> that a libapparmor devel package needs to be installed.
> 
> I am curious if John will complain about the length of the
> SYSTEM_LIBAPPARMOR variable, if he has to remember to define it on
> his make invocations.
> 
well I might once I lose X copy paste when we are forced onto unity7
(but I suspect that will be the breaking point so it won't be an issue
anyways). For now with the message its simple select and middle click,
then I just use bash history.