[apparmor] [PATCH 18/43] apparmor: provide base for multiple profiles to be replaced at once

[John Johansen]

On 02/13/2013 09:56 AM, Seth Arnold wrote:
> On Tue, Feb 12, 2013 at 08:55:28PM -0800, John Johansen wrote:
>>> old and rename do appear to be refcounted:
>>
>> err yes, I believe the comments even say so
>>>> + * @old - Returns: pointer to profile to replace (NO REFCOUNT)
>>>> + * @rename - Returns: pointer to profile to rename (NO REFCOUNT)
>> :)
> 
> Ah, so "NO REFCOUNT" is a command to the programmer, not a warning about
> the behavior of this function. :) Okay. Maybe "Don't refcount" would be
> a more clear command to the future?
> 
> Thanks :)

No, and is. Its a warning to the programmer that the reference returned
does not have a refcount, and hence can not be used outside of the lock.

This means don't put this reference, unless you have done a get on it
yourself.