[apparmor] GSoC r13, r14, r15 review

[Kshitij Gupta]

Hello,


On Wed, Jul 10, 2013 at 12:09 AM, Christian Boltz <apparmor at cboltz.de> wrote:

> I noticed you removed repr() in r16 - does this fix the issue?
> (a short test tells me the answer is probably "no")
>
Actually it did, but then I moved to the error() thing in r16.
Also, its standard to use repr(), so I'll revert to it anyway. A
single long line of exception.

>> I feel I should use the error(), it will print something like this and
>> terminate program:
>>
>> ERROR: No severity value present in file: severity_broken.db
>>     [Line 14]: CAP_SYS_MODULE
>> What would you say? move to error() instead of raising
>> AppArmorException?
>
> Can error() be catched with try/except like an exception? For example,
> we'll need this to display a nice error dialog in YaST.
> (If yes, then using error() is OK.)
>
No it wont be caught, since it simply terminates the program.

Regards,

Kshitij