[apparmor] [PATCH v2] apparmor: implement profile-based query interface in apparmorfs

[Seth Arnold]

On Wed, Mar 06, 2013 at 04:39:00PM -0800, Tyler Hicks wrote:
> > I may have tuned out a discussion on IRC about the 'deny' flags -- at
> > least it feels like a conversation I've ignored :) -- but the profiles
> > currently communicate 'deny' through the 'quiet' flags.
> 
> Oh? I must have misunderstood the quiet flag. I thought quiet overrode
> audit and deny overrode allow.

... and I misunderstood some comments in the code. :) Pretend I said
nothing here. Hehe.

> > Again, nit-picking :) but the name 'count' doesn't sound right; it's
> > being used as a buffer length indicator, not an interation counter.
> 
> You'll have to take this one up with linux-fsdevel. count is the
> conventional name of the third parameter of write()-related functions.
> 
> But, I suppose I can cave and change it if you have a better suggestion.
> :)

Oh, my apologies for missing that it was convention. I hadn't noticed it
when reading through smack's code (either by overlooking it or it being
different.) Anyway, following convention is worth making me squint at it
a little funny every time I see it in the future. :)

Thanks Tyler
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: Digital signature
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20130306/0fc3bacb/attachment.pgp>