[apparmor] [PATCH v2] LibAppArmor.pm: Adjust Makefile dependencies to support parallel builds

[Steve Beattie]

On Sun, Nov 03, 2013 at 11:14:01PM -0800, Tyler Hicks wrote:
> The libapparmor_wrap.c target generates libapparmor_wrap.c and
> LibAppArmor.pm. The Perl module must exist before `perl Makefile.PL`
> under the Makefile.perl target, otherwise the generated Makefile.perl
> ends up with an empty $(TO_INST_PM) variable and the pm_to_blib target's
> dependencies are incomplete. That results in the Perl module not getting
> copied to the blib directory and a build that is missing LibAppArmor.pm.
> 
> A build missing LibAppArmor.pm only occurred while building with
> multiple threads. With this fix, libapparmor should support parallel
> builds.
> 
> Thanks to Seth Arnold for the suggestion on how to best fix the
> dependencies.
> 
> Signed-off-by: Tyler Hicks <tyhicks at canonical.com>

I think there are still other issues within the libapparmor tree around
parallel builds, but this addresses at least one of the issues,
therefore Acked-by: Steve Beattie <steve at nxnw.org>.

Thanks!

-- 
Steve Beattie
<sbeattie at ubuntu.com>
http://NxNW.org/~steve/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20131104/3fa3ec86/attachment.pgp>