[apparmor] [PATCH] parser: Detect core dumps during parser tests

Steve Beattie steve at nxnw.org
Wed Sep 11 09:49:41 UTC 2013


On Wed, Sep 11, 2013 at 01:33:59AM -0700, Tyler Hicks wrote:
> If a parser test case causes the parser to produce a core dump, the
> simple.pl test runner incorrectly treats the test as a success.
> 
> This patch treats tests that cause core dumps as failures, even when the
> tests are marked as #=TODO. The only way to ignore tests that fail in
> this manner is with #=DISABLED.
> 
> Note that this patch changes the meaning of the $result variable.
> Previously, it held a true or false status returned when closing the
> apparmor_parser pipe. Now, it holds the exit status of apparmor_parser.
> 
> Signed-off-by: Tyler Hicks <tyhicks at canonical.com>

Very nice. Acked-by: Steve Beattie <steve at nxnw.org>


-- 
Steve Beattie
<sbeattie at ubuntu.com>
http://NxNW.org/~steve/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20130911/3057941f/attachment.pgp>


More information about the AppArmor mailing list