[apparmor] [patch 2/3] utils: add tests for capability rules classes

Christian Boltz apparmor at cboltz.de
Wed Dec 3 21:14:31 UTC 2014


Hello,

Am Mittwoch, 3. Dezember 2014 schrieb Steve Beattie:
> Patch changes:
>   v5:
>      - merge my changes into Christian's original patches
>      - update to use CapabilityRule.parse() as the entry point for
>        parsing raw rules and getting a CapabilityRule instance in
>        return.
> 
> Originally-by: Christian Boltz <apparmor at cboltz.de>
> Signed-off-by: Steve Beattie <steve at nxnw.org>


> +class InvalidCapabilityTest(unittest.TestCase):
> +    def setUp(self):
> +        self.maxDiff = None
> +
> +    # XXX - these tests more properly belong in a test suite for
> +    # XXX - CapabilityRule.parse()

We moved back the parsing to capability.py, which means this comment is 
now superfluous, so please remove it.

Besides that,
    Acked-by: Christian Boltz <apparmor at cboltz.de>
with the note that large parts of this patch were originally written by 
me, so another review won't hurt ;-)


Regards,

Christian Boltz
-- 
Wenn Du Dich weiter doof stellst, dann:
Warning: loading builtin philipp-cool-down.dll. Couldn't be loaded!
Expect trouble!!!                 [Philipp Zacharias in suse-linux]




More information about the AppArmor mailing list