[apparmor] [patch] delete unused functions check_include_syntax() and check_profile_syntax in aa.py

Kshitij Gupta kgupta8592 at gmail.com
Wed Dec 24 14:16:12 UTC 2014


Hello,

On Sun, Dec 7, 2014 at 2:54 AM, Christian Boltz <apparmor at cboltz.de> wrote:

> Hello,
>
> this patch deletes the unused functions check_include_syntax() and
> check_profile_syntax in aa.py
>
> [ aa.py-delete-unused-func.diff ]
>
> === modified file 'utils/apparmor/aa.py'
> --- utils/apparmor/aa.py        2014-11-29 12:40:10 +0000
> +++ utils/apparmor/aa.py        2014-12-06 21:22:07 +0000
> @@ -2560,14 +2560,6 @@
>          return True
>      return False
>
> -def check_include_syntax(errors):
> -    # To-Do
> -    pass
> -
> -def check_profile_syntax(errors):
> -    # To-Do
> -    pass
> -
>  def read_profiles():
>      try:
>          os.listdir(profile_dir)
>
>
> ahh so there was supposed to be a separate syntax parser for profile and
includes.
Would make sense but we deal with it at processing level now.
So,

Thanks for the cleanup.

Acked-by: Kshitij Gupta <kgupta8592 at gmail.com>.

Regards,

Kshitij Gupta

>
>
> Regards,
>
> Christian Boltz
> --
> > > Dooooooooooooooooooch!!! ;-)
> > N<?php do{echo "e";>!
> cb at tux:~>  echo 'N<?php do{echo "e";>!' | php
> Parse error:  parse error, unexpected '>' in - on line 1
> [> Ratti und Christian Boltz in fontlinge-devel]
>
>
> --
> AppArmor mailing list
> AppArmor at lists.ubuntu.com
> Modify settings or unsubscribe at:
> https://lists.ubuntu.com/mailman/listinfo/apparmor
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20141224/a2903868/attachment.html>


More information about the AppArmor mailing list