[apparmor] [PATCH] add --set-env option to aa-sandbox and move os.chdir()

Christian Boltz apparmor at cboltz.de
Thu Feb 6 20:34:16 UTC 2014


Hello,

Am Donnerstag, 6. Februar 2014 schrieb Jamie Strandboge:
> = aa-sandbox_add_set-env_option.patch =

> +    for e in opt.setenv_vars:
> +        if '=' not in e:
> +            continue

if broken:
    ignore_silently()

;-)

Seriously: if someone calls aa-sandbox with an invalid parameter (that's 
what a missing "=..." is), there should _at least_ be a warning. 
I'd even vote to abort with an error message - that's better than 
running with unexpected / not-overwritten env variables)

And as Steve already noticed, the print looks superfluous.


Regards,

Christian Boltz
-- 
* cboltz votes for the boring version - can't
<sarnold> that's a bit informal for a mandatory security platform :)
<sbeattie> ah, but you see, contractions are informal, and we can't, 
           err can not, err cannot, err can ?not have that.
[from #apparmor, while discussing bugzilla.novell.com/853661]




More information about the AppArmor mailing list