[apparmor] new profile tools - review of merging branch

[Christian Boltz]

Hello,

Am Sonntag, 16. Februar 2014 schrieb Kshitij Gupta:
> Sorry for the delayed response. I wasn't well and have been barely
> crawling in and out of bed.

That's why laptops were invented - you can move them next to your 
bed ;-))

I hope you get well soon!

> I'm starting to catch up all the mails and patches. Please bear with
> me.
> 
> Btw @cboltz, you have the commit rights I suppose. Always feel free to
> commit patches. (They can always be reverted ;) )

AFAIK, I don't have write access to the apparmor-profile-tools repo - 
but that doesn't matter too much.

In the meantime, Steve merged your code into the official repo, with 
some changes and fixes applied [1]. This means the latest code is in the 
official repo (in other words: the apparmor-profile-tools repo is 
outdated ;-) and the development should continue in the apparmor repo.
(I'd propose that you add a notice about this to the apparmor-profile-
tools repo's README.md and then switch over to the apparmor repo.)

This also means that everybody with commit access can commit (after 
following the usual review policy - send the patch to the mailinglist 
and wait for someone to send an ACK before you commit it).

Speaking about commit access - it would be a good idea to give you 
commit access to the apparmor repo ;-)
@Steve or John: can you do that, please?


Regards,

Christian Boltz

[1] some of Steve's changes were quite big, like several whitespace 
    changes to make PEP8 happy. This also means you'll get an unreadable 
    diff ;-)

        bzr log -r 2383 -n0 | less
    will tell you what Steve did (commit messages), and something like
        bzr diff -r2368.1.21..2368.1.22
    will show you what exactly he changed between the two specified 
    revisions.

-- 
> ich habe mir gerade eine DVD mit meinen Daten geschrieben, scheint
> aber nicht lesbar zu sein.
Wie genau hast du sie denn geschrieben?
- Mit einem Stift: Lösung: Hm. In ca 30 cm vor die Nase halten und
  lesen.      [> Anca Tibor Attila und Martin Ereth in suse-linux]