[apparmor] [patch] tests: warn about xpass/xfail marked tests

Steve Beattie steve at nxnw.org
Thu Oct 9 08:26:46 UTC 2014


With the two recent unix socket test patches to mark dgram tests as
failing but expected to pass, I realized that there's no indication
in the output that there are current expected failures (except for
the single corefile test expected failure)[0]. This patch attempts
to remedy that by emitting the x-type plus the test description for
each test that is marked as such. I've set it to always emit these
results; I could be talked into only doing it when VERBOSE is set, but I
think the constant visible reminder is probably for the best.

[0] The test infrastructure does give an alert if there is a test that
    has been marked xpass or xfail but has started behaving correctly.

Signed-off-by: Steve Beattie <steve at nxnw.org>
---
 tests/regression/apparmor/prologue.inc |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Index: b/tests/regression/apparmor/prologue.inc
===================================================================
--- a/tests/regression/apparmor/prologue.inc
+++ b/tests/regression/apparmor/prologue.inc
@@ -250,7 +250,10 @@ checktestfg()
 		fi
 	fi
 
-	if [ -n "$VERBOSE" ]; then
+	# warn about expected failures
+	if [ -n "${_known}" ] ; then
+		echo "x${_pfmode}: ${_testdesc}"
+	elif [ -n "$VERBOSE" ]; then
 		echo "ok: ${_testdesc}"
 	fi
 }

-- 
Steve Beattie
<sbeattie at ubuntu.com>
http://NxNW.org/~steve/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20141009/ad22d446/attachment.pgp>


More information about the AppArmor mailing list