[apparmor] Memory leaks in parser/parser_regex.c (at least)

[intrigeri]

Hi,

Steve Beattie wrote (27 Aug 2015 20:44:58 GMT) :
> It looks like the parser never drops it's reference to the policy cache
> object. This patch looks to fix the issue:

It helps! With your 5 patches applied, including the two ones you've
sent yesterday, the build now stops at:

make[4]: Entering directory '/tmp/buildd/apparmor-2.10/libraries/libapparmor/testsuite/libaalogparse.test'
make[4]: Nothing to be done for 'check'.
make[4]: Leaving directory '/tmp/buildd/apparmor-2.10/libraries/libapparmor/testsuite/libaalogparse.test'
make[4]: Entering directory '/tmp/buildd/apparmor-2.10/libraries/libapparmor/testsuite'
make  check-DEJAGNU
make[5]: Entering directory '/tmp/buildd/apparmor-2.10/libraries/libapparmor/testsuite'
Making a new site.exp file ...
srcdir='.'; export srcdir; \
EXPECT=expect; export EXPECT; \
if /bin/bash -c "runtest --version" > /dev/null 2>&1; then \
  exit_status=0; l='libaalogparse'; for tool in $l; do \
    if runtest  --tool $tool --srcdir $srcdir ; \
    then :; else exit_status=1; fi; \
  done; \
else echo "WARNING: could not find 'runtest'" 1>&2; :;\
fi; \
exit $exit_status
WARNING: Couldn't find tool init file
Test Run By pbuilder on Fri Aug 28 12:40:49 2015
Native configuration is x86_64-pc-linux-gnu

		=== libaalogparse tests ===

Schedule of variations:
    unix

Running target unix
Using /usr/share/dejagnu/baseboards/unix.exp as board description file for target.
Using /usr/share/dejagnu/config/unix.exp as generic interface file for target.
Using ./config/unix.exp as tool-and-target-specific interface file.
Running ./libaalogparse.test/multi_test.exp ...
Running test_multi...
   ... old_style_log_11
   ... testcase_dbus_01
   ... syslog_datetime_02
   ... testcase31
   ... testcase_syslog_rename_src
   ... testcase11
   ... syslog_datetime_14
   ... testcase_network_03
   ... avc_syslog_03
   ... old_style_log_07
   ... syslog_datetime_06
   ... old_style_log_10
   ... syslog_datetime_07
   ... testcase19
   ... testcase_signal_02
   ... syslog_audit_05
   ... testcase04
   ... testcase_mount_01
   ... testcase17
   ... testcase10
   ... testcase_syslog_status_offset
   ... testcase_syslog_capability
   ... avc_syslog_01
   ... old_style_log_05
   ... testcase02
   ... testcase_dbus_03
   ... syslog_datetime_11
   ... testcase_network_04
   ... old_style_log_08
   ... testcase_encoded_comm
   ... syslog_datetime_09
   ... syslog_datetime_18
   ... testcase21
   ... testcase_network_02
   ... testcase_dmesg_rename_dest
FAIL: test case failed for testcase_dmesg_rename_dest: child process exited abnormally
   ... testcase_dbus_04
   ... old_style_log_13
   ... testcase_pivotroot_01
   ... testcase15
   ... syslog_audit_02
   ... avc_audit_02
   ... syslog_datetime_03
   ... testcase16
   ... testcase35
   ... testcase14
   ... old_style_log_01
   ... avc_audit_03
   ... testcase_syslog_rename_dest
   ... testcase_ptrace_01
   ... testcase_changeprofile_01
   ... testcase01
   ... testcase_dbus_05
   ... old_style_log_15
   ... old_style_log_14
   ... syslog_datetime_17
   ... testcase_dmesg_link_01
FAIL: test case failed for testcase_dmesg_link_01: child process exited abnormally
   ... testcase_dmesg_rename_src
FAIL: test case failed for testcase_dmesg_rename_src: child process exited abnormally
   ... old_style_log_09
   ... syslog_audit_01
   ... syslog_audit_06
   ... testcase_network_01
   ... testcase_dmesg_mkdir
FAIL: test case failed for testcase_dmesg_mkdir: child process exited abnormally
   ... syslog_datetime_16
   ... avc_audit_invalid_audit_id
FAIL: test case failed for avc_audit_invalid_audit_id: child process exited abnormally
   ... testcase_ouid
   ... testcase_encoded_profile
   ... testcase33
   ... testcase_dbus_02
   ... old_style_log_16
   ... testcase_stack_crash
   ... syslog_datetime_01
   ... testcase_signal_01
   ... syslog_other_02
FAIL: test case failed for syslog_other_02: child process exited abnormally
   ... old_style_log_03
   ... testcase12
   ... avc_syslog_02
   ... testcase06
   ... testcase26
   ... old_style_log_02
   ... testcase_syslog_mkdir
   ... syslog_datetime_04
   ... testcase32
   ... testcase03
   ... syslog_datetime_15
   ... testcase09
   ... testcase_syslog_link_01
   ... syslog_datetime_08
   ... syslog_datetime_13
   ... testcase_dmesg_truncate
FAIL: test case failed for testcase_dmesg_truncate: child process exited abnormally
   ... testcase18
   ... testcase24
   ... testcase_dbus_06
   ... old_style_log_12
   ... syslog_datetime_12
   ... testcase_dmesg_changehat_negative_error
FAIL: test case failed for testcase_dmesg_changehat_negative_error: child process exited abnormally
   ... avc_audit_01
   ... testcase_network_05
   ... testcase05
   ... testcase25
   ... testcase_syslog_truncate
   ... testcase08
   ... old_style_log_18
   ... syslog_other_03
FAIL: test case failed for syslog_other_03: child process exited abnormally
   ... testcase13
   ... testcase22
   ... syslog_datetime_05
   ... testcase_syslog_changehat_negative_error
   ... syslog_datetime_10
   ... testcase_dmesg_changeprofile_01
FAIL: test case failed for testcase_dmesg_changeprofile_01: child process exited abnormally
   ... old_style_log_06
   ... testcase07
   ... syslog_other_04
FAIL: test case failed for syslog_other_04: child process exited abnormally
   ... testcase_dmesg_capability
FAIL: test case failed for testcase_dmesg_capability: child process exited abnormally
   ... syslog_other_01
FAIL: test case failed for syslog_other_01: child process exited abnormally
   ... old_style_log_04
   ... testcase_dmesg_status_offset
FAIL: test case failed for testcase_dmesg_status_offset: child process exited abnormally
   ... old_style_log_17

		=== libaalogparse Summary ===

# of expected passes		103
# of unexpected failures	14
Makefile:571: recipe for target 'check-DEJAGNU' failed
make[5]: *** [check-DEJAGNU] Error 1
make[5]: Leaving directory '/tmp/buildd/apparmor-2.10/libraries/libapparmor/testsuite'
Makefile:668: recipe for target 'check-am' failed
make[4]: *** [check-am] Error 2
make[4]: Leaving directory '/tmp/buildd/apparmor-2.10/libraries/libapparmor/testsuite'
Makefile:478: recipe for target 'check-recursive' failed
make[3]: *** [check-recursive] Error 1
make[3]: Leaving directory '/tmp/buildd/apparmor-2.10/libraries/libapparmor/testsuite'
Makefile:406: recipe for target 'check-recursive' failed
make[2]: *** [check-recursive] Error 1


Cheers,
-- 
intrigeri