[apparmor] [patch] utils: fix python install for rule/ subdirectory

[Tyler Hicks]

On 2015-01-13 11:33:10, Steve Beattie wrote:
> utils: fix python install for rule/ subdirectory
> 
> For reasons that are unclear to me, python's setuptools doesn't
> install recursively from a directory, meaning that on make install,
> the new Rules/Ruleset classes were not being installed. This patch
> causes the rule subdirectory to be included.
> 
> Bug: https://bugs.launchpad.net/bugs/1407437
> 
> Signed-off-by: Steve Beattie <steve at nxnw.org>

I don't have much experience here but I see that setuptools provides
find_packages() which may be a little more future proof than manually
adding new packages to the list.

  https://pythonhosted.org/setuptools/setuptools.html#using-find-packages

However, I think what you have here is perfectly acceptable and gets my
ack.

Acked-by: Tyler Hicks <tyhicks at canonical.com>

> ---
>  utils/python-tools-setup.py |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: b/utils/python-tools-setup.py
> ===================================================================
> --- a/utils/python-tools-setup.py
> +++ b/utils/python-tools-setup.py
> @@ -81,7 +81,7 @@ setup (name='apparmor',
>         license='GPL-2',
>         cmdclass={'install': Install},
>         package_dir={'apparmor': 'staging'},
> -       packages=['apparmor'],
> +       packages=['apparmor', 'apparmor.rule'],
>         py_modules=['apparmor.easyprof']
>  )
>  
> -- 
> Steve Beattie
> <sbeattie at ubuntu.com>
> http://NxNW.org/~steve/



> -- 
> AppArmor mailing list
> AppArmor at lists.ubuntu.com
> Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/apparmor

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20150113/6508f3fc/attachment.pgp>