[apparmor] [patch] rename _clean to pod_clean in Makefiles

John Johansen john.johansen at canonical.com
Fri Jan 30 21:35:41 UTC 2015


On 01/30/2015 01:21 PM, Christian Boltz wrote:
> Hello,
> 
> Am Freitag, 30. Januar 2015 schrieb John Johansen:
>> On 01/30/2015 12:21 PM, Christian Boltz wrote:
>>> Am Freitag, 30. Januar 2015 schrieb John Johansen:
>>>> On 01/28/2015 01:34 PM, Christian Boltz wrote:
> ...
>>> No, but it seems you didn't write Makefiles for a while ;-)
>>
>> well thats true, but I would say more like I wasn't fully awake
> 
> ;-)
>  
>> with that said, are you sure you want my ack? I might still be asleep
> 
> I hope you had a(nother) coffee before sending the ack ;-)
> 
>>>>> BTW: common/Make.rules uses "-rm -f" which means errors are
>>>>> ignored.
>>>>> What's the reason for doing this? bzr blame isn't too useful - the
>>>>> line was added in r516 (moved into Make.rules from various
>>>>> Makefiles), but all those Makefiles used "rm -f" (without -), and
>>>>> there's no explanation why the - was added.
> 
> This still wasn't answered ;-)
> 
> Does someone have a good reason for ignoring errors in pod_clean?
> 
sorry I don't. I assume its because clean got run before Make and there
was nothing there to clean, so there was an error. Now whether that
was because making the pods was optional or not or for some other
reason, I don't know.






More information about the AppArmor mailing list