[apparmor] [patch 3/5] tests: onexec - check and report signal failure

steve at nxnw.org steve at nxnw.org
Fri Mar 18 17:29:07 UTC 2016


The onexec test was ignoring errors from the kill() call, so it didn't
notice when it had unsuccessfully sent SIGSTOP to itself.

Signed-off-by: Steve Beattie <steve at nxnw.org>
---
 tests/regression/apparmor/onexec.c |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

Index: b/tests/regression/apparmor/onexec.c
===================================================================
--- a/tests/regression/apparmor/onexec.c
+++ b/tests/regression/apparmor/onexec.c
@@ -45,7 +45,12 @@ int main(int argc, char *argv[])
 
 	/* stop after onexec and wait to for continue before exec so
 	 * caller can introspect task */
-	(void)kill(getpid(), SIGSTOP);
+	rc = kill(getpid(), SIGSTOP);
+	if (rc == -1){
+		fprintf(stderr, "FAIL: signal to self failed - %s\n",
+			strerror(errno));
+		exit(errno);
+	}
 
 	(void)execve(argv[2], &argv[2], environ);
 	/* exec failed, kill outselves to flag parent */




More information about the AppArmor mailing list