[apparmor] [patch] Move str_to_mode() tests to test-aamode.py

Steve Beattie steve at nxnw.org
Mon Oct 10 20:32:57 UTC 2016


On Sun, Oct 09, 2016 at 08:32:48PM +0200, Christian Boltz wrote:
> aa_test.py doesn't run in 'make check' because its filename doesn't
> match the 'test-*.py' pattern, so this move means the tests now actually
> get run.
> 
> While on it, migrate test-aamode.py to use the AATest base class, and
> migrate the str_to_mode() tests to a tests[] array.
> 
> After this move, aa_test.py doesn't do anything anymore, so delete it.
> 
> [ 04-move-str_to_mode-tests-to-test-aamode.diff ]

Acked-by: Steve Beattie <steve at nxnw.org>.

Can you also include the following:
---
 utils/test/test-aamode.py |    1 +
 1 file changed, 1 insertion(+)

Index: b/utils/test/test-aamode.py
===================================================================
--- a/utils/test/test-aamode.py
+++ b/utils/test/test-aamode.py
@@ -50,6 +50,7 @@ class AamodeTest_str_to_mode(AATest):
         ('P',   apparmor.aamode.AA_EXEC_PROFILE),
         ('c',   apparmor.aamode.AA_EXEC_CHILD | apparmor.aamode.AA_EXEC_UNSAFE),
         ('C',   apparmor.aamode.AA_EXEC_CHILD),
+        (None,  set()),
     ]
 
     def _run_test(self, params, expected):

Thanks.

-- 
Steve Beattie
<sbeattie at ubuntu.com>
http://NxNW.org/~steve/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20161010/0b1a2d72/attachment.pgp>


More information about the AppArmor mailing list