[apparmor] [patch] Drop seen_events counter from aa.py

Steve Beattie steve at nxnw.org
Fri Oct 14 19:16:52 UTC 2016


On Fri, Oct 14, 2016 at 12:43:19AM +0200, Christian Boltz wrote:
> seen_events is a global variable in aa.py that gets increased at several
> places, but isn't used (read or printed) anywhere. Since I can't imagine
> how it could become useful, simply drop it.

I've no problem dropping this variable if we're not using it anywhere.

That said, I know previously in the development of the perl version
of the tools, there was some experimentation with showing things like
progress bars or information like e.g. "37 of 146 pending rejections
would be covered by adding this rule". I think there's a place for
indicators that show contextual information about the current run of
whatever tool is being used, and this variable may have been added
as a data gathering element to support that.

-- 
Steve Beattie
<sbeattie at ubuntu.com>
http://NxNW.org/~steve/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20161014/11a3b04a/attachment.pgp>


More information about the AppArmor mailing list