[apparmor] [patch] [28/38] AARE: let match() handle plain path regexes as non-regex

[Christian Boltz]

Hello,

Am Donnerstag, 29. September 2016, 12:10:48 CEST schrieb Steve Beattie:
> On Thu, Sep 29, 2016 at 08:48:21PM +0200, Christian Boltz wrote:
> > Am Montag, 26. September 2016, 14:45:34 CEST schrieb Steve Beattie:
> > > On Fri, Aug 12, 2016 at 11:03:09PM +0200, Christian Boltz wrote:

> > > > [ 28-aare-plain-path.diff ]
> > > 
> > > Acked-by: Steve Beattie <steve at nxnw.org>, though I'm not crazy
> > > about
> > > commingling the plain checks with the regex checks in the same
> > > function, as I suspect it will make figuring out what's failing
> > > when
> > > something goes wrong more difficult (in answering "What's being
> > > tested and why?").
> > 
> > Please allow me to disagree ;-)
> 
> Sorry, I wrote my comment particularly poorly. My complaint was
> about commingling the regex and non-regex checks in the *testcases*
> in test/test-aare.py, not the implementation itself in match(). My
> apologies for the confusion.

Ah, ok.

I probably don't need to mention that this was the easiest way to extend 
the test coverage to everything that doesn't look like a regex.

Also, there is a difference: the previously existing check will error 
out with "... object: %s", while the new one will print 
"...object: AARE(%s)".


On the positive side of misunderstanding your comment, we now have a 
nice explanation about plain path handling in AARE (and why it's done 
the way it's done) in the list archives ;-)


Regards,

Christian Boltz
-- 
>In Yast2-System-Editor /etc/sysconfig-Dateien in
>System-Kernel-MODULES_LOADED_ON_BOOT ide-scsi eintragen.
*JAUUUUUUUULLLLL* *ARRRGGHHHH*
Man reiche mir eine Klinik-Jahrespackung von $SCHMERZMITTEL!!!
[> Heinz Dittmar und David Haller in suse-linux]
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20160929/4db3a9d2/attachment.pgp>