[apparmor] [PATCH 2/2] libapparmor: Don't print shell commands that check for test failures

[Christian Boltz]

Hello,

Am Donnerstag, 20. April 2017, 21:32:41 CEST schrieb Tyler Hicks:
> On 04/20/2017 02:28 PM, Tyler Hicks wrote:
> > Error messages shouldn't show up in build logs when the error has
> > been encountered. This patch silences these shell commands from
> > being printed before they're interpreted.
> 
> Typo in the first sentence above. Changed locally to:
> 
> "Error messages should only show up in build logs when the error has
> been encountered."
> 
> Tyler
> 
> > Signed-off-by: Tyler Hicks <tyhicks at canonical.com>
> > ---
> > 
> >  libraries/libapparmor/testsuite/Makefile.am | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/libraries/libapparmor/testsuite/Makefile.am
> > b/libraries/libapparmor/testsuite/Makefile.am index
> > 2cde5cc..55dcb68 100644
> > --- a/libraries/libapparmor/testsuite/Makefile.am
> > +++ b/libraries/libapparmor/testsuite/Makefile.am
> > 
> > @@ -18,7 +18,7 @@ clean-local:
> >  	rm -f libaalogparse.log libaalogparse.sum
> >  
> >  check-local: check-DEJAGNU
> > 
> > -	if ! test -f libaalogparse.log ; then echo '*** 
libaalogparse.log
> > not found - is dejagnu installed? ***'; exit 1; fi -	if grep ERROR
> > libaalogparse.log ; then exit 1 ; fi
> > +	@if ! test -f libaalogparse.log ; then echo '*** 
libaalogparse.log
> > not found - is dejagnu installed? ***'; exit 1; fi +	@if grep ERROR
> > libaalogparse.log ; then exit 1 ; fi
> > 
> >  EXTRA_DIST = test_multi/*.in test_multi/*.out test_multi/*.err

That makes lots of sense :-)

Acked-by: Christian Boltz <apparmor at cboltz.de> for trunk, 2.11, 2.10 and 
2.9


Regards,

Christian Boltz
-- 
Nööö ... das will ich nicht. Ich bin mitlerweile viel zu bequem
geworden und will mir mein KDE nicht mehr wegdenken. (Ausserdem
muss ich meine Hardware auch nutzen - sonst hätte ich sie mir nicht
kaufen müssen! Wozu 512 MB, wenn ich nicht mal 256 MB voll kriegen
würde? Hier hilft KDE sehr! :-)) ) [Konrad Neitzel in suse-linux]
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20170420/b83132e9/attachment.pgp>