[apparmor] [PATCH] json support for logprof and genprof

[Goldwyn Rodrigues]

On 06/14/2017 07:33 AM, Christian Boltz wrote:
> Hello,
> 
> Am Dienstag, 13. Juni 2017, 18:10:54 CEST schrieb Goldwyn Rodrigues:
>> From: Goldwyn Rodrigues <rgoldwyn at suse.com>
>>
>> Provides json support to tools in order to interact with other
>> utilities such as Yast.
>>
>> The JSON output is one per line, in order to differentiate between
>> multiple records. Each JSON record has a "dialog" entry which defines
>> the type of message passed. A response must contain the "dialog"
>> entry. "info" message does not require a response.
>>
>> "apparmor-json-version" added in order to identify the communication
>> protocol version for future updates.
>>
>> This is based on work done by Christian Boltz.
>>
>> Signed-off-by: Goldwyn Rodrigues <rgoldwyn at suse.com>
> ...
>> Changes since v4:
>>  - Comments spacing
>>  - response error to print the entire JSON string received
>>  - Make sure the control goes through, for validation of ans and
>> selected.
> 
> Thanks for the updated patch!
> 
> I'd still like to see some tests, but nevertheless -

Yes, I would like to put them in as well. However, this apparmor effort
has taken too much of my time that my mainstream work has suffered. I
will surely get back to it, and hopefully it would be less than a year
this time. ;)

Thanks for your help!

> 
> Acked-by: Christian Boltz <apparmor at cboltz.de>
> 
> Since this is based on a proof of concept patch I wrote a year ago [1], 
> this partially means reviewing my own work. Therefore I'd like to see a 
> second review.
> 
> If nobody objects until saturday, I'll commit to bzr trunk.
> 
> 
> Regards,
> 
> Christian Boltz
> 
> [1] actually a year and two weeks - I wrote that patch at the openSUSE
>     Conference 2016, and the openSUSE Conference 2017 was just two weeks
>     ago
> 
> 
> 

-- 
Goldwyn