[apparmor] [administrivia] git conversion complete; gitlab projects set up

Tyler Hicks tyhicks at canonical.com
Wed Nov 1 23:57:48 UTC 2017


On 11/01/2017 06:36 PM, Tyler Hicks wrote:
> On 11/01/2017 06:34 PM, Seth Arnold wrote:
>> On Wed, Nov 01, 2017 at 03:46:17PM -0500, Tyler Hicks wrote:
>>> What the maintainer did for the GitHub contribution that I mentioned
>>> above was to merge my pull request into a local branch, interactive
>>> rebase to add his Signed-off-by, and then push the resulting branch to
>>> to the master branch on GitHub.
>>
>> This sounds like a lot of overhead and extra work. What does the extra
>> annotation buy that is lacking from a more simplistic merge?
> 
> An in-tree audit trail of who acked and/or committed the patches.

A possible alternative could be to include this information in the merge
commit. If you look at a merge request, there's a 'Modify commit
message' button that lets you put arbitrary text into the merge commit.
I haven't seen a project do that but that doesn't mean much.

Tyler

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20171101/5d8c4b3e/attachment.sig>


More information about the AppArmor mailing list