Rev 2181: Handle short http reads better. (Ladeuil) in /home/pqm/archives/thelove/bzr/+trunk/

[Canonical.com Patch Queue Manager]

------------------------------------------------------------
revno: 2181
revision-id: pqm at pqm.ubuntu.com-20061213055227-6159e82aef3f15a6
parent: pqm at pqm.ubuntu.com-20061213004620-1b7fef7dd0db37f0
parent: aaron.bentley at utoronto.ca-20061213050719-c7d4iis3sc240qrl
committer: Canonical.com Patch Queue Manager<pqm at pqm.ubuntu.com>
branch nick: +trunk
timestamp: Wed 2006-12-13 05:52:27 +0000
message:
  Handle short http reads better.  (Ladeuil)
modified:
  NEWS                           NEWS-20050323055033-4e00b5db738777ff
  bzrlib/tests/HttpServer.py     httpserver.py-20061012142527-m1yxdj1xazsf8d7s-1
  bzrlib/tests/test_http.py      testhttp.py-20051018020158-b2eef6e867c514d9
  bzrlib/tests/test_transport_implementations.py test_transport_implementations.py-20051227111451-f97c5c7d5c49fce7
  bzrlib/transport/http/__init__.py http_transport.py-20050711212304-506c5fd1059ace96
  bzrlib/transport/http/_pycurl.py pycurlhttp.py-20060110060940-4e2a705911af77a6
  bzrlib/transport/http/_urllib2_wrappers.py _urllib2_wrappers.py-20060913231729-ha9ugi48ktx481ao-1
  bzrlib/transport/http/response.py _response.py-20060613154423-a2ci7hd4iw5c7fnt-1
    ------------------------------------------------------------
    merged: aaron.bentley at utoronto.ca-20061213050719-c7d4iis3sc240qrl
    parent: aaron.bentley at utoronto.ca-20061213044014-ovrud8mi4aii2x22
    committer: Aaron Bentley <aaron.bentley at utoronto.ca>
    branch nick: revert-missing
    timestamp: Wed 2006-12-13 00:07:19 -0500
    message:
      Grammar fixes
    ------------------------------------------------------------
    merged: aaron.bentley at utoronto.ca-20061213044014-ovrud8mi4aii2x22
    parent: pqm at pqm.ubuntu.com-20061213004620-1b7fef7dd0db37f0
    parent: v.ladeuil+lp at free.fr-20061211081033-8pevgxemh4dtuwsk
    committer: Aaron Bentley <aaron.bentley at utoronto.ca>
    branch nick: revert-missing
    timestamp: Tue 2006-12-12 23:40:14 -0500
    message:
      Merge short read fixes
    ------------------------------------------------------------
    merged: v.ladeuil+lp at free.fr-20061211081033-8pevgxemh4dtuwsk
    parent: v.ladeuil+lp at free.fr-20061208175742-ki7ztka2ozv3p2ki
    committer: v.ladeuil+lp at free.fr
    branch nick: bzr.73948
    timestamp: Mon 2006-12-11 09:10:33 +0100
    message:
      Fix the missing import and typos in comments.
      
      * bzrlib/transport/http/__init__.py:
      (HttpTransportBase._retry_get): Explain why we re-raise the
      original exception.
    ------------------------------------------------------------
    merged: v.ladeuil+lp at free.fr-20061208175742-ki7ztka2ozv3p2ki
    parent: pqm at pqm.ubuntu.com-20061208100138-33b6d8665ca29dad
    parent: v.ladeuil+lp at free.fr-20061201151429-l84e47xqynm1pfzm
    committer: v.ladeuil+lp at free.fr
    branch nick: bzr.73948
    timestamp: Fri 2006-12-08 18:57:42 +0100
    message:
      Merge a recent bzr.dev (2172) and takes John's remarks into account.
    ------------------------------------------------------------
    merged: v.ladeuil+lp at free.fr-20061201151429-l84e47xqynm1pfzm
    parent: v.ladeuil+lp at free.fr-20061201150629-zjd2an87u0r7nhhw
    committer: v.ladeuil+lp at free.fr
    branch nick: bzr.curl.persistence
    timestamp: Fri 2006-12-01 16:14:29 +0100
    message:
      Update NEWS.
    ------------------------------------------------------------
    merged: v.ladeuil+lp at free.fr-20061201150629-zjd2an87u0r7nhhw
    parent: v.ladeuil+lp at free.fr-20061130174947-gsx0zu8d50jdy0j2
    committer: v.ladeuil+lp at free.fr
    branch nick: bzr.curl.persistence
    timestamp: Fri 2006-12-01 16:06:29 +0100
    message:
      The tests that would have help avoid bug #73948 and all that mess :)
      
      * bzrlib/transport/http/response.py:
      (handle_response): Translate a 416 http error code into a bzr
      exception.
      
      * bzrlib/transport/http/_urllib2_wrappers.py:
      (HTTPDefaultErrorHandler.http_error_default): Translate a 416 http
      error code into a bzr exception.
      
      * bzrlib/transport/http/_pycurl.py:
      (PyCurlTransport._curl_perform): It could happen that pycrul
      itself detect a short read.
      
      * bzrlib/transport/http/__init__.py:
      (HttpTransportBase._retry_get): New method, factorizing the retry
      logic.
      (HttpTransportBase.readv): We can have exception during the
      initial GET worth degrading the range requirements (i.e. retrying
      the GET request with either single or not ranges).
      
      * bzrlib/tests/test_transport_implementations.py:
      (TransportTests.test_readv_short_read): InvalidRange can also be
      raised.
      
      * bzrlib/tests/test_http.py:
      (TestRangeRequestServer.test_readv_invalid_ranges): Was named
      test_readv_short_read, the new name make the intent
      clearer. Depending of the code path used (urllib or pycurl), both
      exceptions can be raised.
      
      * bzrlib/tests/HttpServer.py:
      (TestingHTTPRequestHandler.do_GET): If invalid ranges are
      specified, returns a 416 instead of the whole file (both are valid
      according to the RFC).