Rev 2421: (Andrew Bennetts) Rename SmartClient to _SmartClient. in file:///home/pqm/archives/thelove/bzr/%2Btrunk/

[Canonical.com Patch Queue Manager]

At file:///home/pqm/archives/thelove/bzr/%2Btrunk/

------------------------------------------------------------
revno: 2421
revision-id: pqm at pqm.ubuntu.com-20070416180853-ucztrxo25i0fci62
parent: pqm at pqm.ubuntu.com-20070416080254-bf3rfk77k5bgfdl7
parent: andrew.bennetts at canonical.com-20070416163837-9oujyp3f2mzuvlqr
committer: Canonical.com Patch Queue Manager<pqm at pqm.ubuntu.com>
branch nick: +trunk
timestamp: Mon 2007-04-16 19:08:53 +0100
message:
  (Andrew Bennetts) Rename SmartClient to _SmartClient.
modified:
  bzrlib/smart/client.py         client.py-20061116014825-2k6ada6xgulslami-1
  bzrlib/tests/test_smart_transport.py test_ssh_transport.py-20060608202016-c25gvf1ob7ypbus6-2
    ------------------------------------------------------------
    revno: 2414.1.4
    merged: andrew.bennetts at canonical.com-20070416163837-9oujyp3f2mzuvlqr
    parent: andrew.bennetts at canonical.com-20070416052458-t2shorpdp62yodh3
    committer: Andrew Bennetts <andrew.bennetts at canonical.com>
    branch nick: hpss-miscellany-2
    timestamp: Tue 2007-04-17 02:38:37 +1000
    message:
      Rename SmartClient to _SmartClient.
=== modified file 'bzrlib/smart/client.py'
--- a/bzrlib/smart/client.py	2007-04-16 02:44:04 +0000
+++ b/bzrlib/smart/client.py	2007-04-16 16:38:37 +0000
@@ -20,7 +20,7 @@
 from bzrlib.urlutils import unescape
 
 
-class SmartClient(object):
+class _SmartClient(object):
 
     def __init__(self, medium):
         self._medium = medium

=== modified file 'bzrlib/tests/test_smart_transport.py'
--- a/bzrlib/tests/test_smart_transport.py	2007-04-16 08:02:54 +0000
+++ b/bzrlib/tests/test_smart_transport.py	2007-04-16 18:08:53 +0000
@@ -1453,14 +1453,14 @@
 
 
 class TestSmartClientUnicode(tests.TestCase):
-    """SmartClient tests for unicode arguments.
+    """_SmartClient tests for unicode arguments.
 
     Unicode arguments to call_with_body_bytes are not correct (remote method
     names, arguments, and bodies must all be expressed as byte strings), but
-    SmartClient should gracefully reject them, rather than getting into a broken
-    state that prevents future correct calls from working.  That is, it should
-    be possible to issue more requests on the medium afterwards, rather than
-    allowing one bad call to call_with_body_bytes to cause later calls to
+    _SmartClient should gracefully reject them, rather than getting into a
+    broken state that prevents future correct calls from working.  That is, it
+    should be possible to issue more requests on the medium afterwards, rather
+    than allowing one bad call to call_with_body_bytes to cause later calls to
     mysteriously fail with TooManyConcurrentRequests.
     """
 
@@ -1472,7 +1472,7 @@
         input = StringIO("\n")
         output = StringIO()
         client_medium = medium.SmartSimplePipesClientMedium(input, output)
-        smart_client = client.SmartClient(client_medium)
+        smart_client = client._SmartClient(client_medium)
         self.assertRaises(TypeError,
             smart_client.call_with_body_bytes, method, args, body)
         self.assertEqual("", output.getvalue())