Rev 425: Remove unnecessary initialization, add assertions. in http://people.samba.org/bzr/jelmer/bzr-svn/bzr.dev

[Jelmer Vernooij]

At http://people.samba.org/bzr/jelmer/bzr-svn/bzr.dev

------------------------------------------------------------
revno: 425
revision-id: jelmer at samba.org-20070210135306-h57124ufb6re4ekz
parent: jelmer at samba.org-20070202194810-u6ce2rs57hzaykt4
parent: jelmer at samba.org-20070207224558-4c461v1nvsd293r5
committer: Jelmer Vernooij <jelmer at samba.org>
branch nick: main
timestamp: Sat 2007-02-10 14:53:06 +0100
message:
  Remove unnecessary initialization, add assertions.
modified:
  branchprops.py                 branchprops.py-20061223204623-80lvm7pjrpsgk0dd-1
  logwalker.py                   logwalker.py-20060621215743-c13fhfnyzh1xzwh2-1
  transport.py                   transport.py-20060406231150-b3472d06b3a0818d
    ------------------------------------------------------------
    revno: 424.1.1
    merged: jelmer at samba.org-20070207224558-4c461v1nvsd293r5
    parent: jelmer at samba.org-20070202194810-u6ce2rs57hzaykt4
    committer: Jelmer Vernooij <jelmer at samba.org>
    branch nick: main
    timestamp: Wed 2007-02-07 23:45:58 +0100
    message:
      Remove unnecessary initialization.
=== modified file 'branchprops.py'
--- a/branchprops.py	2007-01-02 16:58:01 +0000
+++ b/branchprops.py	2007-02-10 13:53:06 +0000
@@ -44,10 +44,12 @@
 
         return props
 
-    def get_properties(self, path, revnum):
+    def get_properties(self, path, origrevnum):
+        assert path is not None
+        assert isinstance(origrevnum, int) and origrevnum >= 0
         proplist = {}
-        revnum = self.log.find_latest_change(path, revnum)
-        assert revnum is not None
+        revnum = self.log.find_latest_change(path, origrevnum)
+        assert revnum is not None, "can't find latest change for %r:%r" % (path, origrevnum)
 
         proplist = {}
         for (name, value) in self.cachedb.execute("select name, value from branchprop where revnum=%d and branchpath='%s'" % (revnum, path)):

=== modified file 'logwalker.py'
--- a/logwalker.py	2007-02-02 19:48:10 +0000
+++ b/logwalker.py	2007-02-10 13:53:06 +0000
@@ -219,6 +219,8 @@
         :param path: Path to check for changes
         :param revnum: First revision to check
         """
+        assert isinstance(path, str)
+        assert isinstance(revnum, int) and revnum >= 0
         if revnum > self.saved_revnum:
             self.fetch_revisions(revnum)
 

=== modified file 'transport.py'
--- a/transport.py	2007-02-02 19:48:10 +0000
+++ b/transport.py	2007-02-07 22:45:58 +0000
@@ -31,10 +31,6 @@
 
 from errors import convert_svn_error
 
-# Some older versions of the Python bindings need to be 
-# explicitly initialized
-svn.ra.initialize()
-
 svn_config = svn.core.svn_config_get_config(None)