Rev 2841: Review feedback. in http://people.ubuntu.com/~robertc/baz2.0/repository

[Robert Collins]

At http://people.ubuntu.com/~robertc/baz2.0/repository

------------------------------------------------------------
revno: 2841
revision-id: robertc at robertcollins.net-20071017204821-sovi7e8mkji4gb0q
parent: robertc at robertcollins.net-20071017093941-v7d1djrt2617citb
committer: Robert Collins <robertc at robertcollins.net>
branch nick: repository
timestamp: Thu 2007-10-18 06:48:21 +1000
message:
  Review feedback.
modified:
  bzrlib/index.py                index.py-20070712131115-lolkarso50vjr64s-1
  bzrlib/repofmt/pack_repo.py    pack_repo.py-20070813041115-gjv5ma7ktfqwsjgn-1
  bzrlib/tests/repository_implementations/helpers.py helpers.py-20070924032407-m460yl9j5gu5ju85-2
=== modified file 'bzrlib/index.py'
--- a/bzrlib/index.py	2007-10-17 09:39:41 +0000
+++ b/bzrlib/index.py	2007-10-17 20:48:21 +0000
@@ -268,7 +268,7 @@
         self._size = size
 
     def __eq__(self, other):
-        """Equal when self and otherwere created with the same parameters."""
+        """Equal when self and other were created with the same parameters."""
         return (
             type(self) == type(other) and
             self._transport == other._transport and

=== modified file 'bzrlib/repofmt/pack_repo.py'
--- a/bzrlib/repofmt/pack_repo.py	2007-10-17 09:39:41 +0000
+++ b/bzrlib/repofmt/pack_repo.py	2007-10-17 20:48:21 +0000
@@ -1618,18 +1618,7 @@
 
 
 class RepositoryFormatGraphKnit1(RepositoryFormatPack):
-    """Experimental pack based repository with knit1 style data.
-
-    This repository format has:
-     - knits for file texts and inventory
-     - hash subdirectory based stores.
-     - knits for revisions and signatures
-     - uses a GraphKnitIndex for revisions.knit.
-     - TextStores for revisions and signatures.
-     - a format marker of its own
-     - an optional 'shared-storage' flag
-     - an optional 'no-working-trees' flag
-     - a LockDir lock
+    """A no-subtrees parameterised Pack repository.
 
     This format was introduced in bzr.dev.
     """
@@ -1646,9 +1635,6 @@
 
     _matchingbzrdir = property(_get_matching_bzrdir, _ignore_setting_bzrdir)
 
-    def __ne__(self, other):
-        return self.__class__ is not other.__class__
-
     def get_format_string(self):
         """See RepositoryFormat.get_format_string()."""
         return "Bazaar Experimental no-subtrees\n"
@@ -1662,20 +1648,13 @@
 
 
 class RepositoryFormatGraphKnit3(RepositoryFormatPack):
-    """Experimental repository with knit3 style data.
+    """A subtrees parameterised Pack repository.
 
-    This repository format has:
-     - knits for file texts and inventory
-     - hash subdirectory based stores.
-     - knits for revisions and signatures
-     - uses a GraphKnitIndex for revisions.knit.
-     - TextStores for revisions and signatures.
-     - a format marker of its own
-     - an optional 'shared-storage' flag
-     - an optional 'no-working-trees' flag
-     - a LockDir lock
+    This repository format uses the xml7 serializer to get:
      - support for recording full info about the tree root
      - support for recording tree-references
+
+    This format was introduced in bzr.dev.
     """
 
     repository_class = GraphKnitRepository
@@ -1706,4 +1685,4 @@
 
     def get_format_description(self):
         """See RepositoryFormat.get_format_description()."""
-        return "Experimental no-subtrees\n"
+        return "Experimental subtrees\n"

=== modified file 'bzrlib/tests/repository_implementations/helpers.py'
--- a/bzrlib/tests/repository_implementations/helpers.py	2007-10-17 09:39:41 +0000
+++ b/bzrlib/tests/repository_implementations/helpers.py	2007-10-17 20:48:21 +0000
@@ -62,7 +62,7 @@
             repo.abort_write_group()
             repo.unlock()
             raise
-        finally:
+        else:
             repo.commit_write_group()
             repo.unlock()