Rev 3202: * The launchpad plugin now uses the ``edge`` xmlrpc server to avoid in http://people.ubuntu.com/~robertc/baz2.0/register-branch.public_location

Robert Collins robertc at robertcollins.net
Fri Jan 25 11:06:52 GMT 2008


At http://people.ubuntu.com/~robertc/baz2.0/register-branch.public_location

------------------------------------------------------------
revno: 3202
revision-id:robertc at robertcollins.net-20080125110632-0tp2cjae2ol63zuq
parent: robertc at robertcollins.net-20080125104610-4qweeqqch2feyxdv
committer: Robert Collins <robertc at robertcollins.net>
branch nick: register-branch.public_location
timestamp: Fri 2008-01-25 22:06:32 +1100
message:
   * The launchpad plugin now uses the ``edge`` xmlrpc server to avoid
     interacting badly with a bug on the launchpad side. (Robert Collins)
modified:
  NEWS                           NEWS-20050323055033-4e00b5db738777ff
  bzrlib/plugins/launchpad/lp_registration.py lp_registration.py-20060315190948-daa617eafe3a8d48
  bzrlib/plugins/launchpad/test_register.py test_register.py-20060315182712-40f5dda945c829a8
=== modified file 'NEWS'
--- a/NEWS	2008-01-25 10:46:10 +0000
+++ b/NEWS	2008-01-25 11:06:32 +0000
@@ -57,6 +57,9 @@
     * ``reconfigure`` preserves tags when converting to and from lightweight
       checkouts.  (Aaron Bentley, #182040)
 
+    * The launchpad plugin now uses the ``edge`` xmlrpc server to avoid
+      interacting badly with a bug on the launchpad side. (Robert Collins)
+
     * Unknown hostnames when connecting to a ``bzr://`` URL no longer cause
       tracebacks.  (Andrew Bennetts, #182849)
 

=== modified file 'bzrlib/plugins/launchpad/lp_registration.py'
--- a/bzrlib/plugins/launchpad/lp_registration.py	2008-01-25 10:46:10 +0000
+++ b/bzrlib/plugins/launchpad/lp_registration.py	2008-01-25 11:06:32 +0000
@@ -40,7 +40,11 @@
 
     # NB: this should always end in a slash to avoid xmlrpclib appending
     # '/RPC2'
-    DEFAULT_SERVICE_URL = 'https://xmlrpc.launchpad.net/bazaar/'
+    # We use edge because:
+    # Beta users get redirected to it
+    # All users can use it
+    # There is a bug in the launchpad side where redirection causes an OOPS.
+    DEFAULT_SERVICE_URL = 'https://xmlrpc.edge.launchpad.net/bazaar/'
 
     transport = None
     registrant_email = None

=== modified file 'bzrlib/plugins/launchpad/test_register.py'
--- a/bzrlib/plugins/launchpad/test_register.py	2008-01-25 10:46:10 +0000
+++ b/bzrlib/plugins/launchpad/test_register.py	2008-01-25 11:06:32 +0000
@@ -185,7 +185,7 @@
                 'author at launchpad.net',
                 'product')
         rego.submit(service)
-        self.assertEquals(transport.connected_host, 'xmlrpc.launchpad.net')
+        self.assertEquals(transport.connected_host, 'xmlrpc.edge.launchpad.net')
         self.assertEquals(len(transport.sent_params), 6)
         self.assertEquals(transport.sent_params,
                 ('http://test-server.com/bzr/branch',  # branch_url
@@ -202,7 +202,7 @@
         service = LaunchpadService(transport)
         resolve = ResolveLaunchpadPathRequest('bzr')
         resolve.submit(service)
-        self.assertEquals(transport.connected_host, 'xmlrpc.launchpad.net')
+        self.assertEquals(transport.connected_host, 'xmlrpc.edge.launchpad.net')
         self.assertEquals(len(transport.sent_params), 1)
         self.assertEquals(transport.sent_params, ('bzr', ))
         self.assertTrue(transport.got_request)



More information about the bazaar-commits mailing list