Rev 3409: Fixed as par John's review. in http://code.launchpad.net/%7Evila/bzr/226769-selftest-hanging-with-strace

[Vincent Ladeuil]

At http://code.launchpad.net/%7Evila/bzr/226769-selftest-hanging-with-strace

------------------------------------------------------------
revno: 3409
revision-id: v.ladeuil+lp at free.fr-20080507175404-25btczc2cdbyulfd
parent: v.ladeuil+lp at free.fr-20080507133707-hfscqf32riufeqx7
committer: Vincent Ladeuil <v.ladeuil+lp at free.fr>
branch nick: 226769-selftest-hanging-with-strace
timestamp: Wed 2008-05-07 19:54:04 +0200
message:
  Fixed as par John's review.
  
  * test_strace.py:
  (TestStrace): Update comment.
modified:
  bzrlib/tests/test_strace.py    test_strace.py-20070323001526-6zquhhw8leb9m6j8-2
-------------- next part --------------
=== modified file 'bzrlib/tests/test_strace.py'
--- a/bzrlib/tests/test_strace.py	2008-05-07 13:37:07 +0000
+++ b/bzrlib/tests/test_strace.py	2008-05-07 17:54:04 +0000
@@ -50,13 +50,12 @@
 
     _test_needs_features = [StraceFeature]
 
-    # If the following tests are activated, selftest may hang (see bug
-    # #226769). This is due to strace strange behavior when required to trace
-    # its own parent in the presence of threads (or something like that). One
-    # strace is fixed, we may want to activate these tests again. Note: running
-    # these tests in isolation is still possible.
-
     def _check_threads(self):
+        # For bug #226769, it was decided that the strace tests should not be
+        # run when more than one thread is active. A lot of tests are currently
+        # leaking threads for good or bad reasons, once they are fixed or
+        # strace itself is fixed (bug #103133), we can get rid of the
+        # restriction.
         active = threading.activeCount()
         if active > 1: # There is always the main thread at least
             raise tests.KnownFailure(