Rev 3743: Martin's review feedback. in file:///v/home/vila/src/bzr/experimental/bzr-py26-compat/

Vincent Ladeuil v.ladeuil+lp at free.fr
Mon Sep 29 08:09:44 BST 2008


At file:///v/home/vila/src/bzr/experimental/bzr-py26-compat/

------------------------------------------------------------
revno: 3743
revision-id: v.ladeuil+lp at free.fr-20080929070943-bw01lbtpek13rub2
parent: v.ladeuil+lp at free.fr-20080929070355-mi1n0opzn3mxgg1q
committer: Vincent Ladeuil <v.ladeuil+lp at free.fr>
branch nick: deprecations
timestamp: Mon 2008-09-29 09:09:43 +0200
message:
  Martin's review feedback.
  
  * bzrlib/revisionspec.py:
  (RevisionSpec.__new__): Deleted. It has been deprecated last
  century (0.11).
  
  * bzrlib/osutils.py: 
  Use _mod prefixe when importing symbols.
-------------- next part --------------
=== modified file 'bzrlib/osutils.py'
--- a/bzrlib/osutils.py	2008-09-29 07:03:55 +0000
+++ b/bzrlib/osutils.py	2008-09-29 07:09:43 +0000
@@ -55,10 +55,10 @@
 # sha and md5 modules are deprecated in python2.6 but hashlib is available as
 # of 2.5
 if sys.version_info < (2, 5):
-    import md5 as _md5
-    md5 = _md5.new
-    import sha as _sha
-    sha = _sha.new
+    import md5 as _mod_md5
+    md5 = _mod_md5.new
+    import sha as _mod_sha
+    sha = _mod_sha.new
 else:
     from hashlib import (
         md5,

=== modified file 'bzrlib/revisionspec.py'
--- a/bzrlib/revisionspec.py	2008-09-25 16:02:34 +0000
+++ b/bzrlib/revisionspec.py	2008-09-29 07:09:43 +0000
@@ -137,17 +137,6 @@
     prefix = None
     wants_revision_history = True
 
-    def __new__(cls, spec, _internal=False):
-        if _internal:
-            return object.__new__(cls)
-
-        symbol_versioning.warn('Creating a RevisionSpec directly has'
-                               ' been deprecated in version 0.11. Use'
-                               ' RevisionSpec.from_string()'
-                               ' instead.',
-                               DeprecationWarning, stacklevel=2)
-        return RevisionSpec.from_string(spec)
-
     @staticmethod
     def from_string(spec):
         """Parse a revision spec string into a RevisionSpec object.



More information about the bazaar-commits mailing list