Rev 4858: 2 test_repository tests weren't adding cleanups when opening files. in http://bazaar.launchpad.net/~jameinel/bzr/2.1.0b4-win32-test-cleanups

John Arbash Meinel john at arbash-meinel.com
Thu Dec 3 20:05:42 GMT 2009


At http://bazaar.launchpad.net/~jameinel/bzr/2.1.0b4-win32-test-cleanups

------------------------------------------------------------
revno: 4858
revision-id: john at arbash-meinel.com-20091203200529-no7ltq6gew22392l
parent: pqm at pqm.ubuntu.com-20091203050805-s70sybyrsrbbs10c
committer: John Arbash Meinel <john at arbash-meinel.com>
branch nick: 2.1.0b4-win32-test-cleanups
timestamp: Thu 2009-12-03 14:05:29 -0600
message:
  2 test_repository tests weren't adding cleanups when opening files.
-------------- next part --------------
=== modified file 'bzrlib/tests/test_repository.py'
--- a/bzrlib/tests/test_repository.py	2009-11-08 23:59:07 +0000
+++ b/bzrlib/tests/test_repository.py	2009-12-03 20:05:29 +0000
@@ -1427,6 +1427,7 @@
             index_class=BTreeGraphIndex,
             use_chk_index=False)
         pack = pack_repo.NewPack(collection)
+        self.addCleanup(pack.abort) # Make sure the write stream gets closed
         self.assertIsInstance(pack.revision_index, BTreeBuilder)
         self.assertIsInstance(pack.inventory_index, BTreeBuilder)
         self.assertIsInstance(pack._hash, type(osutils.md5()))
@@ -1485,6 +1486,7 @@
         packer = pack_repo.OptimisingPacker(self.get_pack_collection(),
                                             [], '.test')
         new_pack = packer.open_pack()
+        self.addCleanup(new_pack.abort) # ensure cleanup
         self.assertIsInstance(new_pack, pack_repo.NewPack)
         self.assertTrue(new_pack.revision_index._optimize_for_size)
         self.assertTrue(new_pack.inventory_index._optimize_for_size)



More information about the bazaar-commits mailing list