Rev 35: (ugly hack) autopacking doesn't work, so don't do it. in http://bazaar.launchpad.net/%7Ebzr/bzr-groupcompress/trunk

John Arbash Meinel john at arbash-meinel.com
Wed Feb 18 20:41:21 GMT 2009


At http://bazaar.launchpad.net/%7Ebzr/bzr-groupcompress/trunk

------------------------------------------------------------
revno: 35
revision-id: john at arbash-meinel.com-20090218204046-yyqr5q4tza4v4xug
parent: john at arbash-meinel.com-20090218203905-8npi7rmtgt1lup4h
committer: John Arbash Meinel <john at arbash-meinel.com>
branch nick: trunk
timestamp: Wed 2009-02-18 14:40:46 -0600
message:
  (ugly hack) autopacking doesn't work, so don't do it.
  Force the fetch order and delta logic to use fulltexts in topological order.
  It isn't great, but it means things work.
-------------- next part --------------
=== modified file 'repofmt.py'
--- a/repofmt.py	2009-02-17 19:35:38 +0000
+++ b/repofmt.py	2009-02-18 20:40:46 +0000
@@ -229,6 +229,9 @@
         self.repo.signatures._index._add_callback = self.signature_index.add_callback
         self.repo.texts._index._add_callback = self.text_index.add_callback
 
+    def _do_autopack(self):
+        return False
+
 
 
 class GCPackRepository(KnitPackRepository):
@@ -301,6 +304,14 @@
         self._reconcile_does_inventory_gc = True
         self._reconcile_fixes_text_parents = True
         self._reconcile_backsup_inventory = False
+        # Note: We cannot unpack a delta that references a text we haven't seen yet.
+        #       there are 2 options, work in fulltexts, or require topological
+        #       sorting. Using fulltexts is more optimal for local operations,
+        #       because the source can be smart about extracting multiple
+        #       in-a-row (and sharing strings). Topological is better for
+        #       remote, because we access less data.
+        self._fetch_order = 'topological'
+        self._fetch_uses_deltas = False
 
 
 if chk_support:
@@ -362,6 +373,8 @@
             self._reconcile_does_inventory_gc = True
             self._reconcile_fixes_text_parents = True
             self._reconcile_backsup_inventory = False
+            self._fetch_order = 'topological'
+            self._fetch_uses_deltas = False
 
 
 class RepositoryFormatPackGCPlain(RepositoryFormatPackDevelopment2):



More information about the bazaar-commits mailing list