Rev 4195: Review tweaks. in http://people.ubuntu.com/~robertc/baz2.0/pending/Remote.negative_parents_cache

[Robert Collins]

At http://people.ubuntu.com/~robertc/baz2.0/pending/Remote.negative_parents_cache

------------------------------------------------------------
revno: 4195
revision-id: robertc at robertcollins.net-20090324213428-rol001c1jypq9y30
parent: robertc at robertcollins.net-20090324070911-w59etn9q3f9xj4fu
committer: Robert Collins <robertc at robertcollins.net>
branch nick: Remote.negative_parents_cache
timestamp: Wed 2009-03-25 08:34:28 +1100
message:
  Review tweaks.
=== modified file 'bzrlib/graph.py'
--- a/bzrlib/graph.py	2009-03-24 07:09:11 +0000
+++ b/bzrlib/graph.py	2009-03-24 21:34:28 +0000
@@ -153,8 +153,6 @@
         if cache is None:
             cache = self._get_parent_map(keys)
         else:
-            # XXX: Full scan of cache, keeping a set of cached keys will scale
-            # better.
             needed_revisions = set(key for key in keys if key not in cache)
             # Do not ask for negatively cached keys
             needed_revisions.difference_update(self.missing_keys)

=== modified file 'bzrlib/smart/repository.py'
--- a/bzrlib/smart/repository.py	2009-03-24 06:07:35 +0000
+++ b/bzrlib/smart/repository.py	2009-03-24 21:34:28 +0000
@@ -134,7 +134,7 @@
         from revision_ids is returned. The verb takes a body containing the
         current search state, see do_body for details.
 
-        If 'include-missing' is in revision_ids, ghosts encountered in the
+        If 'include-missing:' is in revision_ids, ghosts encountered in the
         graph traversal for getting parent data are included in the result with
         a prefix of 'missing:'.