Rev 4784: Clarify the comment as to why we are checking __init__ in http://bazaar.launchpad.net/~jameinel/bzr/475585-lp-proxy-py24-compat

John Arbash Meinel john at arbash-meinel.com
Thu Nov 5 18:32:55 GMT 2009


At http://bazaar.launchpad.net/~jameinel/bzr/475585-lp-proxy-py24-compat

------------------------------------------------------------
revno: 4784
revision-id: john at arbash-meinel.com-20091105183231-9vet6uiv1i7ckiq8
parent: v.ladeuil+lp at free.fr-20091105175454-j1phc0jt5jnkfilp
committer: John Arbash Meinel <john at arbash-meinel.com>
branch nick: 475585-lp-proxy-py24-compat
timestamp: Thu 2009-11-05 12:32:31 -0600
message:
  Clarify the comment as to why we are checking __init__
-------------- next part --------------
=== modified file 'bzrlib/plugins/launchpad/lp_registration.py'
--- a/bzrlib/plugins/launchpad/lp_registration.py	2009-11-05 17:54:54 +0000
+++ b/bzrlib/plugins/launchpad/lp_registration.py	2009-11-05 18:32:31 +0000
@@ -57,9 +57,10 @@
 class XMLRPCTransport(xmlrpclib.Transport):
 
     def __init__(self, scheme):
+        # In python2.4 xmlrpclib.Transport is a old-style class, and does not
+        # define __init__, so we check first
         init = getattr(xmlrpclib.Transport, '__init__', None)
         if init is not None:
-            # Not available before python2.5
             init(self)
         self._scheme = scheme
         self._opener = _urllib2_wrappers.Opener()



More information about the bazaar-commits mailing list