Rev 15: Don't read tags we won't use in http://bazaar.launchpad.net/~canonical-bazaar/udd/hottest100

John Arbash Meinel john at arbash-meinel.com
Tue Jan 26 11:25:08 GMT 2010


At http://bazaar.launchpad.net/~canonical-bazaar/udd/hottest100

------------------------------------------------------------
revno: 15
revision-id: john at arbash-meinel.com-20100126112434-9ld7y009awbx6kxw
parent: john at arbash-meinel.com-20100126111215-hf3dixh5p9j25m2k
committer: John Arbash Meinel <john at arbash-meinel.com>
branch nick: hottest100
timestamp: Tue 2010-01-26 05:24:34 -0600
message:
  Don't read tags we won't use
-------------- next part --------------
=== modified file 'check-hottest.py'
--- a/check-hottest.py	2010-01-26 11:12:15 +0000
+++ b/check-hottest.py	2010-01-26 11:24:34 +0000
@@ -56,7 +56,7 @@
         f.close()
     
 
-def get_branch_age_and_tags(location):
+def get_branch_age_and_tags(location, tags=True):
     global reuse_transports
     dir = bzrdir.BzrDir.open(location, possible_transports=reuse_transports)
     reuse_transports = [dir.transport]
@@ -65,10 +65,12 @@
     try:
         rev = branch.repository.get_revision(branch.last_revision())
         dt = datetime.datetime.fromtimestamp(rev.timestamp)
-        try:
-            tag_dict = branch.tags.get_tag_dict()
-        except errors.TagsNotSupported:
-            tag_dict = {}
+        tag_dict = {}
+        if tags:
+            try:
+                tag_dict = branch.tags.get_tag_dict()
+            except errors.TagsNotSupported:
+                pass # No tags here
         return datetime.datetime.now() - dt, tag_dict
     finally:
         branch.unlock()
@@ -176,7 +178,8 @@
                 broken_packages.add(package)
         try:
             upstream_branch_url = 'lp:%s' % (package.name,)
-            age, _ = get_branch_age_and_tags(upstream_branch_url)
+            age, _ = get_branch_age_and_tags(upstream_branch_url,
+                                             tags=False)
             output_stream.write(fmt_str
                                 % (upstream_branch_url, age.days, '', ''))
             if age.days < opts.stale_days:



More information about the bazaar-commits mailing list