Rev 5297: Add some FIXMEs in file:///home/vila/src/bzr/experimental/leaking-tests/

Vincent Ladeuil v.ladeuil+lp at free.fr
Tue Jun 29 17:11:18 BST 2010


At file:///home/vila/src/bzr/experimental/leaking-tests/

------------------------------------------------------------
revno: 5297
revision-id: v.ladeuil+lp at free.fr-20100629161118-9h7ffdrdikenj96h
parent: v.ladeuil+lp at free.fr-20100623164656-3d05qk7c628jfrwm
committer: Vincent Ladeuil <v.ladeuil+lp at free.fr>
branch nick: smart-server-leaks
timestamp: Tue 2010-06-29 18:11:18 +0200
message:
  Add some FIXMEs
-------------- next part --------------
=== modified file 'bzrlib/smart/server.py'
--- a/bzrlib/smart/server.py	2010-06-18 07:51:17 +0000
+++ b/bzrlib/smart/server.py	2010-06-29 16:11:18 +0000
@@ -65,6 +65,7 @@
         self.backing_transport = backing_transport
         self.root_client_path = root_client_path
 
+    # FIXME: Needs to be public and be called start_server ? -- vila 20100624
     def _create_server_socket(self, host, port):
         """Create the server listening socket.
 
@@ -194,6 +195,7 @@
         connection_thread.start()
         return connection_thread
 
+    # FIXME: Not needed if we use SmartTCPServer_for_testing ? -- vila 20100624
     def start_background_thread(self, thread_name_suffix=''):
         self._started.clear()
         self._server_thread = threading.Thread(None,



More information about the bazaar-commits mailing list