Rev 4751: (bug #586926) We accidentally were raising a string exception. in http://bazaar.launchpad.net/~jameinel/bzr/2.0-string-exception-586926

[John Arbash Meinel]

At http://bazaar.launchpad.net/~jameinel/bzr/2.0-string-exception-586926

------------------------------------------------------------
revno: 4751
revision-id: john at arbash-meinel.com-20100528175955-r9r7e0xm03zq1d51
parent: pqm at pqm.ubuntu.com-20100520223813-83z0q2ejj4a2ipq7
fixes bug(s): https://launchpad.net/bugs/586926
committer: John Arbash Meinel <john at arbash-meinel.com>
branch nick: 2.0-string-exception-586926
timestamp: Fri 2010-05-28 12:59:55 -0500
message:
  (bug #586926) We accidentally were raising a string exception.
  
  Now we don't.
-------------- next part --------------
=== modified file 'NEWS'
--- a/NEWS	2010-05-20 21:23:47 +0000
+++ b/NEWS	2010-05-28 17:59:55 +0000
@@ -26,6 +26,9 @@
   permissions as ``.bzr`` directory on a POSIX OS.
   (Parth Malwankar, #262450)
 
+* Raise ValueError instead of a string exception.
+  (John Arbash Meinel, #586926)
+
 * Reduce peak memory by one copy of compressed text.
   (John Arbash Meinel, #566940)
 

=== modified file 'bzrlib/bundle/bundle_data.py'
--- a/bzrlib/bundle/bundle_data.py	2009-05-06 05:36:28 +0000
+++ b/bzrlib/bundle/bundle_data.py	2010-05-28 17:59:55 +0000
@@ -1,4 +1,4 @@
-# Copyright (C) 2006 Canonical Ltd
+# Copyright (C) 2005-2010 Canonical Ltd
 #
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -327,7 +327,7 @@
                 try:
                     name, value = info_item.split(':', 1)
                 except ValueError:
-                    raise 'Value %r has no colon' % info_item
+                    raise ValueError('Value %r has no colon' % info_item)
                 if name == 'last-changed':
                     last_changed = value
                 elif name == 'executable':