Rev 5619: (jelmer) Omit Proc Maps from the apport debug when bzr crashes. (Martin Pool) in file:///home/pqm/archives/thelove/bzr/%2Btrunk/

[Canonical.com Patch Queue Manager]

At file:///home/pqm/archives/thelove/bzr/%2Btrunk/

------------------------------------------------------------
revno: 5619 [merge]
revision-id: pqm at pqm.ubuntu.com-20110119015019-rjy0csgtwo4ohi0i
parent: pqm at pqm.ubuntu.com-20110119010343-vqp4ddfjjddplr0v
parent: mbp at canonical.com-20110118002504-k2zox5vr2au5jvjc
committer: Canonical.com Patch Queue Manager <pqm at pqm.ubuntu.com>
branch nick: +trunk
timestamp: Wed 2011-01-19 01:50:19 +0000
message:
  (jelmer) Omit Proc Maps from the apport debug when bzr crashes. (Martin Pool)
modified:
  bzrlib/crash.py                crash.py-20090812083334-d6volool4lktdjcx-1
=== modified file 'bzrlib/crash.py'
--- a/bzrlib/crash.py	2010-09-28 18:51:47 +0000
+++ b/bzrlib/crash.py	2011-01-18 00:25:04 +0000
@@ -143,10 +143,11 @@
     exc_type, exc_object, exc_tb = exc_info
 
     pr = Report()
-    # add_proc_info gives you the memory map of the process, which is not so
-    # useful for Bazaar but does tell you what binary libraries are loaded.
-    # More importantly it sets the ExecutablePath, InterpreterPath, etc.
+    # add_proc_info sets the ExecutablePath, InterpreterPath, etc.
     pr.add_proc_info()
+    # It also adds ProcMaps which for us is rarely useful and mostly noise, so
+    # let's remove it.
+    del pr['ProcMaps']
     pr.add_user_info()
 
     # Package and SourcePackage are needed so that apport will report about even