[PATCH] win32 ScratchBranch must close lockfile before deleting

Martin Pool mbp at sourcefrog.net
Thu Jun 2 05:03:28 BST 2005


On Tue, 2005-05-31 at 21:17 -0500, John A Meinel wrote:
> On windows, a file cannot be deleted if it is already open. Since
> Branch() holds the lockfile open ScratchBranch() has to close it before
> shutil.rmtree will work.
> 
> Attached is a patch that just closes self._lockfile() before deleting.
> This makes all self-tests pass.

Thanks, I think this is fixed now (but by a different method).

> All of the tests still don't pass, since .bzrignore is still being
> read/written in the wrong format (binary versus non-binary).

I'll check that out.

-- 
Martin






More information about the bazaar mailing list