[PATCH] bzr tracks permissions

John A Meinel john at arbash-meinel.com
Mon Jun 6 18:57:49 BST 2005


Attached is a patch to have bzr include permission (mode, owner, group)
into the inventory files.
I have checked that it works with "bzr status" and "bzr commit".
testbzr passes, though only with python2.4 (since python2.3 requires all
modules to actually have tests, not my error, currently the error of
bzr-mainline rev635).

I haven't figured out how to include the information that permissions
have changed. Also, it is certainly likely that some things like
owner/group should not be committed all the time. (It means that when
you do an rsync of mainline, it will look like every file has changed
since it has a new owner & group).

Mostly I just wanted to get this patch out to get some feedback.
Especially how to handle user/group issues.

I'm thinking that it might be best to include user&group in the commit,
but if they are different, it isn't considered a 'diff'.

We could also just not revctl user/group at all, and let higher-level
pieces support that. Or have it be an options flag inside the tree. I
think I favor the options flag. So that someone who wants to revctl /etc
 or $HOME can do so. But by default the only bit that is checked is the
execute bit.

Also, this also needs merge() to be updated, so that it will also merge
the permission bits.

John
=:->
-------------- next part --------------
A non-text attachment was scrubbed...
Name: add-permissions-to-inventory.patch
Type: text/x-patch
Size: 10524 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20050606/eb9ba791/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 251 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20050606/eb9ba791/attachment.pgp 


More information about the bazaar mailing list