[BUG] bzr selftest fails if BZREMAIL is set

[John A Meinel]

Robert Collins wrote:
> On Thu, 2005-09-15 at 11:11 -0400, John A Meinel wrote:
>
>>It seems that the test for checking "bzr whoami" does not unset the
>>BZREMAIL environment variable. So on my system, it ends up using my
>>email rather than the one it is trying to use, and the selftest fails.
>>(This is with both the integration branch, and the bzr.dev mainline).
>>
>>To reproduce just do:
>>
>>BZREMAIL="something <other at normal.net>" ./bzr selftest
>>
>>The attached patch unsets BZREMAIL to test the $wd/.bzr/email file, and
>>then sets it to show that BZREMAIL overrides the $wd/.bzr/email value.
>>
>>I'm assuming that is the intentional behavior, it was just not tested.
>>
>>John
>>=:->
>>
>>PS> This is a single revision, so the changeset should be able to
>>reproduce the appropriate information. I did not publish the branch
>>because it is trivial. (You certainly can use patch and not merge)
>
>
> What should I use to apply this and get the revision installed ?
>
> Rob

Since it is trivial, I don't mind if you use patch. But in theory my
changeset plugin available from here:
http://bzr.arbash-meinel.com/plugins/bzr-changeset/

It's been a while since I hacked on that code, and originally I was more
concerned with just generating the changeset, rather than applying it.

That is another thing which hopefully in the future gets pulled in to
the core of bzr. We were working on having a patch-like text which you
could email, and it would be the same as doing just a regular merge on
the other end.

In it's current incarnation, it is capable of regenerating a revision
plus inventory and texts for a single revision (you could send more than
one in a row to get a set), or it can just send a series of revisions,
with the patch all rolled up (so you only get 1 inventory/set of texts).

I still feel that having the revision-xml is more important than the
other ones, because you can understand history, even if you cannot
recreate a specific instance. But certainly some feel that if you are
going to email changesets, you need to email them one changeset at a
time to preserve exact history. (I sometimes like bundled changesets
because if you have cleaned things up, they are easier to read.)

John
=:->



-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 253 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20050916/3972c6c2/attachment.pgp